From 27716fef7814a4036b17724be748b6a21f64b19c Mon Sep 17 00:00:00 2001 From: Chris Boden <cboden@gmail.com> Date: Sat, 19 May 2012 23:01:40 -0400 Subject: [PATCH] [WebSocket] Encoding bug fix In the handshake verifier, make sure we're checking byte length, not string length --- src/Ratchet/WebSocket/Version/RFC6455/HandshakeVerifier.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Ratchet/WebSocket/Version/RFC6455/HandshakeVerifier.php b/src/Ratchet/WebSocket/Version/RFC6455/HandshakeVerifier.php index afad604..6898e2e 100644 --- a/src/Ratchet/WebSocket/Version/RFC6455/HandshakeVerifier.php +++ b/src/Ratchet/WebSocket/Version/RFC6455/HandshakeVerifier.php @@ -104,7 +104,7 @@ class HandshakeVerifier { * @todo The spec says we don't need to base64_decode - can I just check if the length is 24 and not decode? */ public function verifyKey($val) { - return (16 === strlen(base64_decode((string)$val))); + return (16 === mb_strlen(base64_decode((string)$val), '8bit')); } /**