faeez/mxmbsocket
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Repo. Project Releases Wiki Activity

[WAMP] Removed default var from onPublish

Browse Source 
Removed default array being set on WampServerInterface::onPublish
These methods are called by Ratchet's event components
Ratchet will never pass null values
This removes excess requirements from the end developer
This commit is contained in:
Chris Boden 2012-07-22 20:00:25 -04:00
parent 6ee81074d3
commit 491d0c779c
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Ratchet/Wamp/TopicManager.php
View File

@ -67,7 +67,7 @@ class TopicManager implements WsServerInterface, WampServerInterface {
/**
* {@inheritdoc}
*/
public function onPublish(ConnectionInterface $conn, $topic, $event, array $exclude = array(), array $eligible = array()) {
public function onPublish(ConnectionInterface $conn, $topic, $event, array $exclude, array $eligible) {
$this->app->onPublish($conn, $this->getTopic($topic), $event, $exclude, $eligible);
}

2
src/Ratchet/Wamp/WampServerInterface.php
View File

@ -39,5 +39,5 @@ interface WampServerInterface extends ComponentInterface {
* @param array A list of session IDs the message should be excluded from (blacklist)
* @param array A list of session Ids the message should be send to (whitelist)
*/
function onPublish(ConnectionInterface $conn, $topic, $event, array $exclude = array(), array $eligible = array());
function onPublish(ConnectionInterface $conn, $topic, $event, array $exclude, array $eligible);
}

2
tests/Ratchet/Tests/Wamp/TopicManagerTest.php
View File

@ -144,7 +144,7 @@ class TopicManagerTest extends \PHPUnit_Framework_TestCase {
, $this->isType('array')
);
$this->mngr->onPublish($this->conn, 'topic coverage', $msg);
$this->mngr->onPublish($this->conn, 'topic coverage', $msg, array(), array());
}
public function testOnCloseBubbles() {