faeez/mxmbsocket
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Repo. Project Releases Wiki Activity

Silently fail unblock

Browse Source 
If the user unblocks and address that was not blocked, silently fail
This commit is contained in:
Chris Boden 2012-04-29 13:53:10 -04:00
parent 550b32e1e7
commit 852e5777e3
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Ratchet/Component/Server/IpBlackListComponent.php
View File

@ -34,7 +34,9 @@ class IpBlackListComponent implements MessageComponentInterface {
* @return IpBlackList
*/
public function unblockAddress($ip) {
unset($this->_blacklist[$this->filterAddress($ip)]);
if (isset($this->_blacklist[$this->filterAddress($ip)])) {
unset($this->_blacklist[$this->filterAddress($ip)]);
}
return $this;
}

4
tests/Ratchet/Tests/Component/Server/IpBlackListComponentTest.php
View File

@ -84,4 +84,8 @@ class IpBlackListComponentTest extends \PHPUnit_Framework_TestCase {
public function testFilterAddress($expected, $input) {
$this->assertEquals($expected, $this->_comp->filterAddress($input));
}
public function testUnblockingSilentlyFails() {
$this->assertInstanceOf('\\Ratchet\\Component\\Server\\IpBlackListComponent', $this->_comp->unblockAddress('localhost'));
}
}