Done todo's
Removed a bunch of @todo annotations that have been completed
This commit is contained in:
parent
d880d29729
commit
c45962c7b4
@ -6,7 +6,6 @@ use Ratchet\SocketObserver;
|
|||||||
|
|
||||||
/**
|
/**
|
||||||
* Close the connection to the sockets passed in the constructor
|
* Close the connection to the sockets passed in the constructor
|
||||||
* @todo The server does not seem to be notified when a resource is closed by this class...
|
|
||||||
*/
|
*/
|
||||||
class CloseConnection implements ActionInterface {
|
class CloseConnection implements ActionInterface {
|
||||||
/**
|
/**
|
||||||
|
@ -63,7 +63,6 @@ class Socket implements SocketInterface {
|
|||||||
* @param int
|
* @param int
|
||||||
* @throws \InvalidArgumentException
|
* @throws \InvalidArgumentException
|
||||||
* @throws Exception
|
* @throws Exception
|
||||||
* @todo See if this crack-pot scheme works!
|
|
||||||
*/
|
*/
|
||||||
public function select(&$read, &$write, &$except, $tv_sec, $tv_usec = 0) {
|
public function select(&$read, &$write, &$except, $tv_sec, $tv_usec = 0) {
|
||||||
$read = static::mungForSelect($read);
|
$read = static::mungForSelect($read);
|
||||||
|
@ -24,6 +24,7 @@ interface SocketObserver {
|
|||||||
* This is called just before the connection is closed
|
* This is called just before the connection is closed
|
||||||
* @param SocketInterface
|
* @param SocketInterface
|
||||||
* @return Command\CommandInterface|NULL
|
* @return Command\CommandInterface|NULL
|
||||||
|
* @todo This is triggered if the client or server terminates the connection; consider a new onDisconnect if server triggered
|
||||||
*/
|
*/
|
||||||
function onClose(SocketInterface $conn);
|
function onClose(SocketInterface $conn);
|
||||||
}
|
}
|
Loading…
Reference in New Issue
Block a user