From d4d67eba44aee3f4e635d03eef8d373730f2ba2a Mon Sep 17 00:00:00 2001 From: Chris Boden Date: Tue, 1 Nov 2011 09:55:10 -0400 Subject: [PATCH] Cleanup Removed another couple unused methods --- lib/Ratchet/Server.php | 19 ------------------- tests/Ratchet/Tests/ServerTest.php | 2 ++ 2 files changed, 2 insertions(+), 19 deletions(-) diff --git a/lib/Ratchet/Server.php b/lib/Ratchet/Server.php index 667cf53..191b992 100644 --- a/lib/Ratchet/Server.php +++ b/lib/Ratchet/Server.php @@ -59,25 +59,6 @@ class Server implements SocketObserver, \IteratorAggregate { $this->_app = $application; } - /** - * @todo Test this method - */ - public function newCommand($cmd, SocketCollection $sockets) { - $class = __NAMESPACE__ . '\\Server\\Command\\' . $cmd; - if (!class_exists($class)) { - throw new \UnexpectedValueException("Command {$cmd} not found"); - } - - return new $cmd($sockets); - } - - /** - * @param Logging\LoggerInterface - */ - public function setLogger(LoggerInterface $logger) { - $this->_log = $logger; - } - /** * @return ArrayIterator of SocketInterfaces */ diff --git a/tests/Ratchet/Tests/ServerTest.php b/tests/Ratchet/Tests/ServerTest.php index efc82cb..1f7ea82 100644 --- a/tests/Ratchet/Tests/ServerTest.php +++ b/tests/Ratchet/Tests/ServerTest.php @@ -43,12 +43,14 @@ class ServerTest extends \PHPUnit_Framework_TestCase { $this->assertSame($logger, $this->getPrivateProperty($server, '_log')); } +/* public function testLoggerIsSetInMethod() { $logger = new ArrayLogger; $this->_server->setLogger($logger); $this->assertSame($logger, $this->getPrivateProperty($this->_server, '_log')); } +*/ /* public function testGetMasterReturnsCatalyst() {