From 2921d241b909d9bcd37ace9ef3e9ab985cb90b42 Mon Sep 17 00:00:00 2001 From: Chris Boden Date: Sun, 12 Jan 2014 20:51:03 -0500 Subject: [PATCH 1/2] Attempting HHVM on Travis, using installed composer --- .travis.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 7604e9c..2c7bef4 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,7 +4,11 @@ php: - 5.3 - 5.4 - 5.5 + - hhvm + +matrix: + allow_failures: + - php: hhvm before_script: - - curl -s http://getcomposer.org/installer | php - - php composer.phar install --dev --prefer-source + - composer install --dev --prefer-source From d884e37c122c2979422bc6fe5d838437c0df2b47 Mon Sep 17 00:00:00 2001 From: Chris Boden Date: Mon, 17 Feb 2014 09:04:08 -0500 Subject: [PATCH 2/2] [Session] Attempting to fix broken HHVM unit test --- src/Ratchet/Session/SessionProvider.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/Ratchet/Session/SessionProvider.php b/src/Ratchet/Session/SessionProvider.php index 9cd4dd3..9a885e8 100644 --- a/src/Ratchet/Session/SessionProvider.php +++ b/src/Ratchet/Session/SessionProvider.php @@ -56,7 +56,13 @@ class SessionProvider implements MessageComponentInterface, WsServerInterface { $this->setOptions($options); if (null === $serializer) { - $serialClass = __NAMESPACE__ . "\\Serialize\\{$this->toClassCase(ini_get('session.serialize_handler'))}Handler"; // awesome/terrible hack, eh? + // Temporarily fixing HHVM issue w/ reading ini values + $handler_name = ini_get('session.serialize_handler'); + if ('' === $handler_name) { + $handler_name = 'php'; + } + + $serialClass = __NAMESPACE__ . "\\Serialize\\{$this->toClassCase($handler_name)}Handler"; // awesome/terrible hack, eh? if (!class_exists($serialClass)) { throw new \RuntimeException('Unable to parse session serialize handler'); }