faeez/mxmbsocket
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Repo. Project Releases Wiki Activity

Loosened Dependencies

Browse Source 
Removed construct dependency from ApplicationInterface - changing full decorator to changeable stack.
This commit is contained in:
Chris Boden 2012-01-04 11:22:42 -07:00
parent d37237c274
commit ed3cfc16da
4 changed files with 3 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Ratchet/Application/Server/App.php
View File

@ -41,11 +41,7 @@ class App implements ApplicationInterface {
*/ */
protected $_run = true; protected $_run = true;
public function __construct(ApplicationInterface $application = null) { public function __construct(ApplicationInterface $application) {
if (null === $application) {
throw new \UnexpectedValueException("Server requires an application to run off of");
}
$this->_app = $application; $this->_app = $application;
} }

6
lib/Ratchet/Application/WebSocket/App.php
View File

@ -41,11 +41,7 @@ class App implements ApplicationInterface, ConfiguratorInterface {
protected $_mask_payload = false; protected $_mask_payload = false;
public function __construct(ApplicationInterface $app = null) { public function __construct(ApplicationInterface $app) {
if (null === $app) {
throw new \UnexpectedValueException("WebSocket requires an application to run");
}
$this->_app = $app; $this->_app = $app;
$this->_factory = new Factory; $this->_factory = new Factory;
} }

2
lib/Ratchet/Application/WebSocket/WebSocketAppInterface.php
View File

@ -12,7 +12,7 @@ interface WebSocketAppInterface extends ApplicationInterface {
* Currently instead of this, I'm setting header in the Connection object passed around...not sure which I like more * Currently instead of this, I'm setting header in the Connection object passed around...not sure which I like more
* @param string * @param string
*/ */
function setHeaders($headers); //function setHeaders($headers);
/** /**
* @return string * @return string

5
tests/Ratchet/Tests/Application/Server/AppTest.php
View File

@ -36,11 +36,6 @@ class AppTest extends \PHPUnit_Framework_TestCase {
return array_pop($connections); return array_pop($connections);
} }
public function testDoNotAllowStacklessServer() {
$this->setExpectedException('UnexpectedValueException');
new ServerApp;
}
public function testOnOpenPassesClonedSocket() { public function testOnOpenPassesClonedSocket() {
$this->_server->run($this->_catalyst); $this->_server->run($this->_catalyst);
$master = $this->getMasterConnection(); $master = $this->getMasterConnection();