From fe4a97400dbc6c26a67e02dee5af7eafb76fc814 Mon Sep 17 00:00:00 2001 From: Chris Boden Date: Wed, 13 Sep 2017 18:12:50 -0400 Subject: [PATCH] Remove usage of http_parse_message Found a case where http_parse_message failed to parse a valid request header and returned null, which ended up in an uncaught exception being thrown by Guzzle. --- src/Ratchet/Http/HttpRequestParser.php | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/src/Ratchet/Http/HttpRequestParser.php b/src/Ratchet/Http/HttpRequestParser.php index 25bf489..9c44114 100644 --- a/src/Ratchet/Http/HttpRequestParser.php +++ b/src/Ratchet/Http/HttpRequestParser.php @@ -59,18 +59,6 @@ class HttpRequestParser implements MessageInterface { * @return \Psr\Http\Message\RequestInterface */ public function parse($headers) { - if (function_exists('http_parse_message')) { - $parts = http_parse_message($headers); - - return new gPsr\Request( - $parts->requestMethod - , $parts->requestUrl - , $parts->headers - , null - , $parts->httpVersion - ); - } else { - return gPsr\parse_request($headers); - } + return gPsr\parse_request($headers); } }