From 0050245eb4484351643031d6bc92ee0b607a9541 Mon Sep 17 00:00:00 2001 From: DomoChip Date: Thu, 30 Jun 2022 17:23:29 +0200 Subject: [PATCH] Raise error if frame is over 2GB on 32bits PHP --- src/Messaging/MessageBuffer.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/Messaging/MessageBuffer.php b/src/Messaging/MessageBuffer.php index bbc1061..a751508 100644 --- a/src/Messaging/MessageBuffer.php +++ b/src/Messaging/MessageBuffer.php @@ -158,10 +158,12 @@ class MessageBuffer { $payloadLenBytes = $payload_length === 126 ? 2 : 8; $headerSize += $payloadLenBytes; $bytesToUpack = substr($data, $frameStart + 2, $payloadLenBytes); + $payloadLenOver2GB = false if ($payload_length === 126){ $payload_length = unpack('n', $bytesToUpack)[1]; } else { + $payloadLenOver2GB = unpack('N', $bytesToUpack)[1] > 0; //Decode only the 4 first bytes if (PHP_INT_SIZE == 4) { // if 32bits PHP $bytesToUpack = substr($bytesToUpack, 4); //Keep only 4 last bytes $payload_length = unpack('N', $bytesToUpack)[1]; @@ -178,6 +180,10 @@ class MessageBuffer { $closeFrame = $this->newCloseFrame(Frame::CLOSE_PROTOCOL, 'Invalid frame length'); } + if (!$closeFrame && PHP_INT_SIZE == 4 && $payloadLenOver2GB) { + $closeFrame = $this->newCloseFrame(Frame::CLOSE_TOO_BIG, 'Frame over 2GB can\'t be handled on 32bits PHP'); + } + if (!$closeFrame && $this->maxFramePayloadSize > 1 && $payload_length > $this->maxFramePayloadSize) { $closeFrame = $this->newCloseFrame(Frame::CLOSE_TOO_BIG, 'Maximum frame size exceeded'); }