From 86e2484dfe8335d85c6a6f7f44a337d233c2224a Mon Sep 17 00:00:00 2001
From: Chris Boden <cboden@gmail.com>
Date: Sat, 1 Jun 2013 20:24:11 -0400
Subject: [PATCH] Fixing more Guzzle API breaks

---
 Version/Hixie76.php                   | 8 ++++----
 Version/HyBi10.php                    | 3 ++-
 Version/RFC6455.php                   | 4 ++--
 Version/RFC6455/HandshakeVerifier.php | 8 ++++----
 4 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/Version/Hixie76.php b/Version/Hixie76.php
index 069263a..8b0e2c4 100644
--- a/Version/Hixie76.php
+++ b/Version/Hixie76.php
@@ -23,7 +23,7 @@ class Hixie76 implements VersionInterface {
      * {@inheritdoc}
      */
     public function isProtocol(RequestInterface $request) {
-        return !(null === $request->getHeader('Sec-WebSocket-Key2', true));
+        return !(null === $request->getHeader('Sec-WebSocket-Key2'));
     }
 
     /**
@@ -44,13 +44,13 @@ class Hixie76 implements VersionInterface {
             throw new \UnderflowException("Not enough data received to issue challenge response");
         }
 
-        $challenge = $this->sign($request->getHeader('Sec-WebSocket-Key1', true), $request->getHeader('Sec-WebSocket-Key2', true), $body);
+        $challenge = $this->sign((string)$request->getHeader('Sec-WebSocket-Key1'), (string)$request->getHeader('Sec-WebSocket-Key2'), $body);
 
         $headers = array(
             'Upgrade'                => 'WebSocket'
           , 'Connection'             => 'Upgrade'
-          , 'Sec-WebSocket-Origin'   => $request->getHeader('Origin', true)
-          , 'Sec-WebSocket-Location' => 'ws://' . $request->getHeader('Host', true) . $request->getPath()
+          , 'Sec-WebSocket-Origin'   => (string)$request->getHeader('Origin')
+          , 'Sec-WebSocket-Location' => 'ws://' . (string)$request->getHeader('Host') . $request->getPath()
         );
 
         $response = new Response(101, $headers, $challenge);
diff --git a/Version/HyBi10.php b/Version/HyBi10.php
index 0ac41fa..a53d338 100644
--- a/Version/HyBi10.php
+++ b/Version/HyBi10.php
@@ -4,7 +4,8 @@ use Guzzle\Http\Message\RequestInterface;
 
 class HyBi10 extends RFC6455 {
     public function isProtocol(RequestInterface $request) {
-        $version = (int)((string)($request->getHeader('Sec-WebSocket-Version', -1)));
+        $version = (int)(string)$request->getHeader('Sec-WebSocket-Version');
+
         return ($version >= 6 && $version < 13);
     }
 
diff --git a/Version/RFC6455.php b/Version/RFC6455.php
index aab0435..23e166c 100644
--- a/Version/RFC6455.php
+++ b/Version/RFC6455.php
@@ -50,7 +50,7 @@ class RFC6455 implements VersionInterface {
      * {@inheritdoc}
      */
     public function isProtocol(RequestInterface $request) {
-        $version = (int)((string)($request->getHeader('Sec-WebSocket-Version', -1)));
+        $version = (int)(string)$request->getHeader('Sec-WebSocket-Version');
 
         return ($this->getVersionNumber() === $version);
     }
@@ -73,7 +73,7 @@ class RFC6455 implements VersionInterface {
         return new Response(101, array(
             'Upgrade'              => 'websocket'
           , 'Connection'           => 'Upgrade'
-          , 'Sec-WebSocket-Accept' => $this->sign($request->getHeader('Sec-WebSocket-Key'))
+          , 'Sec-WebSocket-Accept' => $this->sign((string)$request->getHeader('Sec-WebSocket-Key'))
         ));
     }
 
diff --git a/Version/RFC6455/HandshakeVerifier.php b/Version/RFC6455/HandshakeVerifier.php
index 7fbf452..838a047 100644
--- a/Version/RFC6455/HandshakeVerifier.php
+++ b/Version/RFC6455/HandshakeVerifier.php
@@ -19,10 +19,10 @@ class HandshakeVerifier {
         $passes += (int)$this->verifyMethod($request->getMethod());
         $passes += (int)$this->verifyHTTPVersion($request->getProtocolVersion());
         $passes += (int)$this->verifyRequestURI($request->getPath());
-        $passes += (int)$this->verifyHost($request->getHeader('Host', true));
-        $passes += (int)$this->verifyUpgradeRequest($request->getHeader('Upgrade', true));
-        $passes += (int)$this->verifyConnection($request->getHeader('Connection', true));
-        $passes += (int)$this->verifyKey($request->getHeader('Sec-WebSocket-Key', true));
+        $passes += (int)$this->verifyHost((string)$request->getHeader('Host'));
+        $passes += (int)$this->verifyUpgradeRequest((string)$request->getHeader('Upgrade'));
+        $passes += (int)$this->verifyConnection((string)$request->getHeader('Connection'));
+        $passes += (int)$this->verifyKey((string)$request->getHeader('Sec-WebSocket-Key'));
         //$passes += (int)$this->verifyVersion($headers['Sec-WebSocket-Version']); // Temporarily breaking functionality
 
         return (7 === $passes);