diff --git a/src/Version/RFC6455/Connection.php b/src/Connection.php similarity index 98% rename from src/Version/RFC6455/Connection.php rename to src/Connection.php index be6d63f..fd404f3 100644 --- a/src/Version/RFC6455/Connection.php +++ b/src/Connection.php @@ -4,6 +4,7 @@ use Ratchet\AbstractConnectionDecorator; use Ratchet\RFC6455\Version\DataInterface; /** + * @deprecated * {@inheritdoc} * @property \StdClass $WebSocket */ diff --git a/src/Version/RFC6455.php b/src/Handshake/Negotiator.php similarity index 89% rename from src/Version/RFC6455.php rename to src/Handshake/Negotiator.php index e70e209..ccddb07 100644 --- a/src/Version/RFC6455.php +++ b/src/Handshake/Negotiator.php @@ -1,48 +1,43 @@ verifier = new RequestVerifier; - public function __construct(ValidatorInterface $validator = null) { - $this->_verifier = new HandshakeVerifier; $this->setCloseCodes(); - if (null === $validator) { - $validator = new Validator; - } - $this->validator = $validator; } @@ -66,7 +61,7 @@ class RFC6455 implements VersionInterface { * {@inheritdoc} */ public function handshake(RequestInterface $request) { - if (true !== $this->_verifier->verifyAll($request)) { + if (true !== $this->verifier->verifyAll($request)) { return new Response(400); } @@ -78,6 +73,7 @@ class RFC6455 implements VersionInterface { } /** + * @deprecated * @param \Ratchet\ConnectionInterface $conn * @param \Ratchet\MessageInterface $coalescedCallback * @return \Ratchet\WebSocket\Version\RFC6455\Connection @@ -95,6 +91,7 @@ class RFC6455 implements VersionInterface { } /** + * @deprecated - The logic belons somewhere else * @param \Ratchet\WebSocket\Version\RFC6455\Connection $from * @param string $data */ @@ -121,6 +118,7 @@ class RFC6455 implements VersionInterface { return $from->close($frame::CLOSE_PROTOCOL); } + // This is server-side specific logic if (!$frame->isMasked()) { return $from->close($frame::CLOSE_PROTOCOL); } @@ -208,6 +206,7 @@ class RFC6455 implements VersionInterface { } /** + * @deprecated * @return RFC6455\Message */ public function newMessage() { @@ -215,6 +214,7 @@ class RFC6455 implements VersionInterface { } /** + * @deprecated * @param string|null $payload * @param bool|null $final * @param int|null $opcode @@ -235,6 +235,7 @@ class RFC6455 implements VersionInterface { } /** + * @deprecated * Determine if a close code is valid * @param int|string * @return bool @@ -252,6 +253,7 @@ class RFC6455 implements VersionInterface { } /** + * @deprecated * Creates a private lookup of valid, private close codes */ protected function setCloseCodes() { diff --git a/src/Version/VersionInterface.php b/src/Handshake/NegotiatorInterface.php similarity index 59% rename from src/Version/VersionInterface.php rename to src/Handshake/NegotiatorInterface.php index 4fdb9f4..624772d 100644 --- a/src/Version/VersionInterface.php +++ b/src/Handshake/NegotiatorInterface.php @@ -1,13 +1,16 @@