faeez/mxmbsocket
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Repo. Project Releases Wiki Activity

Cleanup

Browse Source 
Removed another couple unused methods
This commit is contained in:
Chris Boden 2011-11-01 09:55:10 -04:00
parent 3127efc981
commit d4d67eba44
2 changed files with 2 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
lib/Ratchet/Server.php
View File

@ -59,25 +59,6 @@ class Server implements SocketObserver, \IteratorAggregate {
$this->_app = $application; $this->_app = $application;
} }
/**
* @todo Test this method
*/
public function newCommand($cmd, SocketCollection $sockets) {
$class = __NAMESPACE__ . '\\Server\\Command\\' . $cmd;
if (!class_exists($class)) {
throw new \UnexpectedValueException("Command {$cmd} not found");
}
return new $cmd($sockets);
}
/**
* @param Logging\LoggerInterface
*/
public function setLogger(LoggerInterface $logger) {
$this->_log = $logger;
}
/** /**
* @return ArrayIterator of SocketInterfaces * @return ArrayIterator of SocketInterfaces
*/ */

2
tests/Ratchet/Tests/ServerTest.php
View File

@ -43,12 +43,14 @@ class ServerTest extends \PHPUnit_Framework_TestCase {
$this->assertSame($logger, $this->getPrivateProperty($server, '_log')); $this->assertSame($logger, $this->getPrivateProperty($server, '_log'));
} }
/*
public function testLoggerIsSetInMethod() { public function testLoggerIsSetInMethod() {
$logger = new ArrayLogger; $logger = new ArrayLogger;
$this->_server->setLogger($logger); $this->_server->setLogger($logger);
$this->assertSame($logger, $this->getPrivateProperty($this->_server, '_log')); $this->assertSame($logger, $this->getPrivateProperty($this->_server, '_log'));
} }
*/
/* /*
public function testGetMasterReturnsCatalyst() { public function testGetMasterReturnsCatalyst() {